Skip to content

fix: Reject obvious bad encoding pastes into the Submitter field in submissions#6702

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
pselkirk:fix-6455
Dec 4, 2023
Merged

fix: Reject obvious bad encoding pastes into the Submitter field in submissions#6702
rjsparks merged 1 commit into
ietf-tools:mainfrom
pselkirk:fix-6455

Conversation

@pselkirk

Copy link
Copy Markdown
Contributor

Fixes #6455

@codecov

codecov Bot commented Nov 28, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c1627ed) 88.82% compared to head (fa500d0) 88.82%.
Report is 18 commits behind head on main.

Files Patch % Lines
ietf/submit/forms.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6702   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         285      285           
  Lines       40230    40237    +7     
=======================================
+ Hits        35733    35740    +7     
  Misses       4497     4497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question inline

Comment thread ietf/submit/forms.py
@jennifer-richards jennifer-richards self-requested a review December 4, 2023 19:06
@rjsparks rjsparks merged commit 5006ea5 into ietf-tools:main Dec 4, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject obvious bad encoding pastes into the Submitter field in submissions.

3 participants